Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize Cypress recordings with conditional triggers #3043

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

adeldhis2
Copy link
Collaborator

@adeldhis2 adeldhis2 commented May 2, 2024

Key Changes:

Conditional Recording Triggers: Implemented conditional recording triggers via commit messages and GitHub labels to ensure that Cypress tests are only recorded when necessary.
Parallel Execution Strategies: Refined parallel execution strategies to improve efficiency and resolve test redundancies in GitHub Actions.
Debugging Enhancements: Added detailed debugging outputs to help track the dynamic values of the test environment variables and ensure correct parameter passing in the workflow.
Update Documentation: Updated the documentation to reflect the changes and ensure clarity on the new CI/CD processes.

Expected Outcomes:

Reduced Cypress Cloud Credit Usage: By optimising the conditions under which tests are recorded and uploaded to Cypress Cloud, we anticipate a significant reduction in credit usage.
Increased CI Efficiency: With better management of parallel execution and conditional testing, the CI process should be more efficient, leading to quicker test cycles.

Relevant Links:

GitHub Actions Run: View Run
Cypress Cloud Run: View Run

Jira Ticket:

For more details, please refer to the Jira ticket: DHIS2-17374.

@adeldhis2 adeldhis2 requested a review from jenniferarnesen May 2, 2024 15:31
@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 2, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify May 2, 2024 15:34 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 8, 2024 12:54 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 14, 2024 06:27 Inactive
@adeldhis2 adeldhis2 added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud and removed e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels May 14, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 20, 2024 13:00 Inactive
Copy link

cypress bot commented May 20, 2024

Passing run #2859 ↗︎

0 741 2 0 Flakiness 0

Details:

Merge 7131b9a into 682b4a0...
Project: Data Visualizer App Commit: ea78e5de74 ℹ️
Status: Passed Duration: 08:23 💡
Started: May 29, 2024 8:17 AM Ended: May 29, 2024 8:26 AM

Review all test suite changes for PR #3043 ↗︎

@adeldhis2 adeldhis2 removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label May 20, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 20, 2024 13:55 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 20, 2024 14:17 Inactive
@adeldhis2 adeldhis2 added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label May 20, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 05:31 Inactive
@adeldhis2 adeldhis2 removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label May 21, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 06:16 Inactive
@adeldhis2 adeldhis2 added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label May 21, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 09:53 Inactive
@adeldhis2 adeldhis2 removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label May 21, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 10:40 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 12:42 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 13:18 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 18:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 19:16 Inactive
@adeldhis2 adeldhis2 added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label May 21, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 20:52 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 22, 2024 08:19 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 22, 2024 08:39 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 22, 2024 10:34 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 22, 2024 11:07 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 29, 2024 07:25 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 29, 2024 07:43 Inactive
@adeldhis2 adeldhis2 added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud and removed e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels May 29, 2024
@jenniferarnesen jenniferarnesen force-pushed the dev branch 2 times, most recently from 34479f1 to 2bf0d53 Compare June 4, 2024 08:56
adeldhis2 added 3 commits June 4, 2024 13:11
chore: enhance parallel test execution setup in CI

chore: trigger tests

chore: split e2e testing into separate workflows for GitHub Actions and Cypress Cloud

chore: fix workflow needs typo

chore: adjust e2e workflow triggers for accurate routing

chore: commit to trigger tests

fix
Save over 3 minutes by parallelizing specs across 5 machines
Reduce run time by up to 75%.
@dhis2-bot dhis2-bot temporarily deployed to netlify June 4, 2024 12:15 Inactive
@jenniferarnesen jenniferarnesen merged commit 15dc8d9 into dev Jun 4, 2024
23 checks passed
@jenniferarnesen jenniferarnesen deleted the cypress-record branch June 4, 2024 12:32
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants